Fixed another bug in to_mesh_iter!
This was a more minor bug - but a bug that was making it produce non-manifold geometry.
This commit is contained in:
parent
aba2e24e26
commit
c19e65b962
@ -2,8 +2,7 @@
|
|||||||
|
|
||||||
## Highest priority:
|
## Highest priority:
|
||||||
|
|
||||||
- Clean up `ramhorn_branch` because it's fugly. Also, fix
|
- Clean up `ramhorn_branch` because it's fugly.
|
||||||
non-manifold stuff at higher recursions.
|
|
||||||
- See `automata_scratch/examples.py` and implement some of the tougher
|
- See `automata_scratch/examples.py` and implement some of the tougher
|
||||||
examples.
|
examples.
|
||||||
- `spiral_nested_2` & `spiral_nested_3` (how to compose
|
- `spiral_nested_2` & `spiral_nested_3` (how to compose
|
||||||
@ -15,8 +14,9 @@
|
|||||||
- Elegance & succinctness (my recent closure work may help with this):
|
- Elegance & succinctness (my recent closure work may help with this):
|
||||||
- Why must I repeat myself so much in these definitions?
|
- Why must I repeat myself so much in these definitions?
|
||||||
- What patterns can I factor out? I do some things regularly, like:
|
- What patterns can I factor out? I do some things regularly, like:
|
||||||
the clockwise boundaries, the zigzag connections, the iterating over
|
the clockwise boundaries, the zigzag connections
|
||||||
a `Vec<Vertex>` to transform each element and make another vector.
|
- Procedural macro to shorten this `Tag::Parent`, `Tag::Body`
|
||||||
|
nonsense - and perhaps force to groups of 3?
|
||||||
- Docs on modules
|
- Docs on modules
|
||||||
- Grep for all TODOs in code, really.
|
- Grep for all TODOs in code, really.
|
||||||
- Look at performance. Can I save on copies of geometry by using
|
- Look at performance. Can I save on copies of geometry by using
|
||||||
|
|||||||
@ -203,9 +203,16 @@ impl<S> Rule<S> {
|
|||||||
geom = geom.connect(vec![(geom2, child.vmap.clone())]).0;
|
geom = geom.connect(vec![(geom2, child.vmap.clone())]).0;
|
||||||
// TODO: Fix clone?
|
// TODO: Fix clone?
|
||||||
|
|
||||||
// and backtrack:
|
// If we end recursion on one child, we must end it
|
||||||
|
// similarly on every sibling (i.e. get its geometry &
|
||||||
|
// final geometry, and merge it in) - so we increment
|
||||||
|
// s.next and let the loop re-run.
|
||||||
|
s.next += 1;
|
||||||
|
if s.next >= s.rules.len() {
|
||||||
|
// Backtrack only at the last child:
|
||||||
stack.pop();
|
stack.pop();
|
||||||
n -= 1;
|
n -= 1;
|
||||||
|
}
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user